golang/ent
1
0
Fork 0
mirror of https://github.com/ent/ent.git synced 2026-04-28 13:40:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

dialect/sql/sqlgraph: allow scanning non-numeric IDs in batch creations (#3830)

Browse Source 
* Use same logic between lastInsertId & lastInsertIds

* fix for bulkcreator.insertLastIds
This commit is contained in:
JSH
2024-01-03 16:34:23 -05:00
committed by GitHub
parent 40dfcc82ed
commit 1bcb2fa9cc
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
dialect/sql/sqlgraph/graph.go
View File

@@ -1924,7 +1924,14 @@ func (c *batchCreator) insertLastIDs(ctx context.Context, tx dialect.ExecQuerier
defer rows.Close()
for i := 0; rows.Next(); i++ {
node := c.Nodes[i]
if node.ID.Type.Numeric() {
switch _, ok := node.ID.Value.(field.ValueScanner); {
case ok:
// If the ID implements the sql.Scanner
// interface it should be a pointer type.
if err := rows.Scan(node.ID.Value); err != nil {
return err
}
case node.ID.Type.Numeric():
// Normalize the type to int64 to make it looks
// like LastInsertId.
var id int64
@@ -1932,8 +1939,10 @@ func (c *batchCreator) insertLastIDs(ctx context.Context, tx dialect.ExecQuerier
return err
}
node.ID.Value = id
} else if err := rows.Scan(&node.ID.Value); err != nil {
return err
default:
if err := rows.Scan(&node.ID.Value); err != nil {
return err
}
}
}
return rows.Err()