golang/ent
1
0
Fork 0
mirror of https://github.com/ent/ent.git synced 2026-05-24 09:31:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove ineffective assignments in test (#76)

Browse Source 
Summary:
Don't assign 'typ' if we don't end up checking it.
Pull Request resolved: https://github.com/facebookincubator/ent/pull/76

Differential Revision: D17809445

Pulled By: a8m

fbshipit-source-id: 124b53c2970795c51e8998efebd8e6049f82591a
This commit is contained in:
Christian Muehlhaeuser
2019-10-08 07:18:57 -07:00
committed by Facebook Github Bot
parent 82f91dfcd2
commit 713b22ba60
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
entc/gen/type_test.go
View File

@@ -25,21 +25,21 @@ func TestType(t *testing.T) {
require.Equal("t1", typ.Package())
require.Equal("t", typ.Receiver())
typ, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{
_, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{
Fields: []*load.Field{
{Unique: true, Default: true, Info: &field.TypeInfo{Type: field.TypeInt}},
},
})
require.Error(err, "unique field can not have default")
typ, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{
_, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{
Fields: []*load.Field{
{Sensitive: true, Tag: `yaml:"pwd"`, Info: &field.TypeInfo{Type: field.TypeString}},
},
})
require.Error(err, "sensitive field cannot have tags")
typ, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{
_, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{
Name: "T",
Fields: []*load.Field{
{Name: "foo", Unique: true, Info: &field.TypeInfo{Type: field.TypeInt}},
@@ -48,7 +48,7 @@ func TestType(t *testing.T) {
})
require.Error(err, "field foo redeclared")
typ, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{
_, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{
Name: "T",
Fields: []*load.Field{
{Name: "enums", Info: &field.TypeInfo{Type: field.TypeEnum}, Enums: []string{"A", "A"}},
@@ -56,7 +56,7 @@ func TestType(t *testing.T) {
})
require.Error(err, "duplicate enums")
typ, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{
_, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{
Name: "T",
Fields: []*load.Field{
{Name: "enums", Info: &field.TypeInfo{Type: field.TypeEnum}, Enums: []string{""}},