From 86b9d850ee78d8b926e83b1bb81b446bd997bb6d Mon Sep 17 00:00:00 2001
From: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
Date: Mon, 7 Dec 2020 14:07:13 +0200
Subject: [PATCH] dialect/sql/mysql: remove enum sorting (#1021)

* dialect/sql/mysql: remove enum sorting

Enums are not longer created as sorted values

* Update mysql_test.go
---
 dialect/sql/schema/mysql.go      | 2 --
 dialect/sql/schema/mysql_test.go | 4 +---
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/dialect/sql/schema/mysql.go b/dialect/sql/schema/mysql.go
index 3e45de64c..e11d9e6ff 100644
--- a/dialect/sql/schema/mysql.go
+++ b/dialect/sql/schema/mysql.go
@@ -9,7 +9,6 @@ import (
 	"database/sql/driver"
 	"fmt"
 	"math"
-	"sort"
 	"strconv"
 	"strings"
 
@@ -263,7 +262,6 @@ func (d *MySQL) cType(c *Column) (t string) {
 		for i, e := range c.Enums {
 			values[i] = fmt.Sprintf("'%s'", e)
 		}
-		sort.Strings(values)
 		t = fmt.Sprintf("enum(%s)", strings.Join(values, ", "))
 	case field.TypeUUID:
 		t = "char(36) binary"
diff --git a/dialect/sql/schema/mysql_test.go b/dialect/sql/schema/mysql_test.go
index 5cebd4672..e6a6d4c3f 100644
--- a/dialect/sql/schema/mysql_test.go
+++ b/dialect/sql/schema/mysql_test.go
@@ -264,7 +264,6 @@ func TestMySQL_Create(t *testing.T) {
 						{Name: "name", Type: field.TypeString, Nullable: true},
 						{Name: "enums1", Type: field.TypeEnum, Enums: []string{"a", "b"}}, // add enum.
 						{Name: "enums2", Type: field.TypeEnum, Enums: []string{"a"}},      // remove enum.
-						{Name: "enums3", Type: field.TypeEnum, Enums: []string{"a", "b"}}, // order does not effect.
 					},
 					PrimaryKey: []*Column{
 						{Name: "id", Type: field.TypeInt, Increment: true},
@@ -280,8 +279,7 @@ func TestMySQL_Create(t *testing.T) {
 						AddRow("id", "bigint(20)", "NO", "PRI", "NULL", "auto_increment", "", "").
 						AddRow("name", "varchar(255)", "YES", "YES", "NULL", "", "", "").
 						AddRow("enums1", "enum('a')", "YES", "NO", "NULL", "", "", "").
-						AddRow("enums2", "enum('b', 'a')", "NO", "YES", "NULL", "", "", "").
-						AddRow("enums3", "enum('b', 'a')", "NO", "YES", "NULL", "", "", ""))
+						AddRow("enums2", "enum('b', 'a')", "NO", "YES", "NULL", "", "", ""))
 				mock.ExpectQuery(escape("SELECT `index_name`, `column_name`, `non_unique`, `seq_in_index` FROM `INFORMATION_SCHEMA`.`STATISTICS` WHERE `TABLE_SCHEMA` = (SELECT DATABASE()) AND `TABLE_NAME` = ? ORDER BY `index_name`, `seq_in_index`")).
 					WithArgs("users").
 					WillReturnRows(sqlmock.NewRows([]string{"index_name", "column_name", "non_unique", "seq_in_index"}).