golang/ent
1
0
Fork 0
mirror of https://github.com/ent/ent.git synced 2026-05-24 09:31:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

entc/gen/privacy: mask allow error on policy evaluation

Browse Source 
Signed-off-by: Alex Snast <alexsn@fb.com>
This commit is contained in:
Alex Snast
2020-04-23 09:27:16 +03:00
parent 22e83955c8
commit 8a93447fe5
25 changed files with 290 additions and 290 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
examples/o2m2types/ent/privacy/privacy.go
View File

@@ -57,11 +57,7 @@ type (
// EvalQuery evaluates a query against a query policy.
func (policy QueryPolicy) EvalQuery(ctx context.Context, q ent.Query) error {
for _, rule := range policy {
switch err := rule.EvalQuery(ctx, q); {
case err == nil || errors.Is(err, Skip):
case errors.Is(err, Allow):
return nil
default:
if err := rule.EvalQuery(ctx, q); err != nil && !errors.Is(err, Skip) {
return err
}
}
@@ -91,11 +87,7 @@ type (
// EvalMutation evaluates a mutation against a mutation policy.
func (policy MutationPolicy) EvalMutation(ctx context.Context, m ent.Mutation) error {
for _, rule := range policy {
switch err := rule.EvalMutation(ctx, m); {
case err == nil || errors.Is(err, Skip):
case errors.Is(err, Allow):
return nil
default:
if err := rule.EvalMutation(ctx, m); err != nil && !errors.Is(err, Skip) {
return err
}
}
@@ -119,12 +111,20 @@ type Policy struct {
// EvalQuery forwards evaluation to query policy.
func (policy Policy) EvalQuery(ctx context.Context, q ent.Query) error {
return policy.Query.EvalQuery(ctx, q)
err := policy.Query.EvalQuery(ctx, q)
if errors.Is(err, Allow) {
err = nil
}
return err
}
// EvalMutation forwards evaluation to mutation policy.
func (policy Policy) EvalMutation(ctx context.Context, m ent.Mutation) error {
return policy.Mutation.EvalMutation(ctx, m)
err := policy.Mutation.EvalMutation(ctx, m)
if errors.Is(err, Allow) {
err = nil
}
return err
}
// QueryMutationRule is the interface that groups query and mutation rules.