golang/ent
1
0
Fork 0
mirror of https://github.com/ent/ent.git synced 2026-05-22 09:31:45 +03:00
Code Issues Packages Projects Releases Wiki Activity

entc/gen: ignore immutable fields on Upsert<T>.UpdateNewValues

Browse Source 
Also, for some reason, the TimeMixin.UpdateTime was an immutable field,
but this was incorrent, because the codegen just skip generating
update setters to it. Removing the Immutable modifier allows users
to set this field explicitly.
This commit is contained in:
Ariel Mashraki
2021-10-05 22:27:58 +03:00
committed by Ariel Mashraki
parent b47b46ee6d
commit 9e809635b2
36 changed files with 156 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
dialect/sql/builder_test.go
View File

@@ -1711,8 +1711,8 @@ func TestInsert_OnConflict(t *testing.T) {
t.Run("Postgres", func(t *testing.T) { // And SQLite.
query, args := Dialect(dialect.Postgres).
Insert("users").
Columns("id", "email").
Values("1", "user@example.com").
Columns("id", "email", "creation_time").
Values("1", "user@example.com", 1633279231).
OnConflict(
ConflictColumns("email"),
ConflictWhere(EQ("name", "Ariel")),
@@ -1720,13 +1720,14 @@ func TestInsert_OnConflict(t *testing.T) {
// Update all new values excepts id field.
ResolveWith(func(u *UpdateSet) {
u.SetIgnore("id")
u.SetIgnore("creation_time")
u.Add("version", 1)
}),
UpdateWhere(NEQ("updated_at", 0)),
).
Query()
require.Equal(t, `INSERT INTO "users" ("id", "email") VALUES ($1, $2) ON CONFLICT ("email") WHERE "name" = $3 DO UPDATE SET "id" = "users"."id", "email" = "excluded"."email", "version" = COALESCE("users"."version", 0) + $4 WHERE "updated_at" <> $5`, query)
require.Equal(t, []interface{}{"1", "user@example.com", "Ariel", 1, 0}, args)
require.Equal(t, `INSERT INTO "users" ("id", "email", "creation_time") VALUES ($1, $2, $3) ON CONFLICT ("email") WHERE "name" = $4 DO UPDATE SET "id" = "users"."id", "email" = "excluded"."email", "creation_time" = "users"."creation_time", "version" = COALESCE("users"."version", 0) + $5 WHERE "updated_at" <> $6`, query)
require.Equal(t, []interface{}{"1", "user@example.com", 1633279231, "Ariel", 1, 0}, args)
query, args = Dialect(dialect.Postgres).
Insert("users").