golang/ent
1
0
Fork 0
mirror of https://github.com/ent/ent.git synced 2026-05-06 01:20:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

dialect/sql/schema: integer to string (#954)

Browse Source 
* Allow migrations from integer to string with max length

* switched to entsql.Annotation

* removed manual conversion size checks

* fixed unit tests
This commit is contained in:
Ciaran Liedeman
2020-11-24 18:09:40 +02:00
committed by GitHub
parent d84e6eb6fe
commit bbd41dbc87
46 changed files with 9249 additions and 1424 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
dialect/sql/schema/schema.go
View File

@@ -186,8 +186,7 @@ func (c *Column) ConvertibleTo(d *Column) bool {
case c.Type == field.TypeString && d.Type == field.TypeEnum ||
c.Type == field.TypeEnum && d.Type == field.TypeString:
return true
// Allow conversions to arbitrary length strings
case c.Type.Integer() && d.Type == field.TypeString && d.Size == 0:
case c.Type.Integer() && d.Type == field.TypeString:
return true
}
return c.FloatType() && d.FloatType()

4
dialect/sql/schema/schema_test.go
View File

@@ -41,7 +41,7 @@ func TestColumn_ConvertibleTo(t *testing.T) {
require.False(t, c1.ConvertibleTo(&Column{Type: field.TypeUint16}))
require.False(t, c1.ConvertibleTo(&Column{Type: field.TypeUint32}))
require.True(t, c1.ConvertibleTo(&Column{Type: field.TypeString}))
require.False(t, c1.ConvertibleTo(&Column{Type: field.TypeString, Size: 1}))
require.True(t, c1.ConvertibleTo(&Column{Type: field.TypeString, Size: 1}))
c1 = &Column{Type: field.TypeInt}
require.True(t, c1.ConvertibleTo(&Column{Type: field.TypeInt}))
@@ -53,7 +53,7 @@ func TestColumn_ConvertibleTo(t *testing.T) {
require.False(t, c1.ConvertibleTo(&Column{Type: field.TypeUint16}))
require.False(t, c1.ConvertibleTo(&Column{Type: field.TypeUint32}))
require.True(t, c1.ConvertibleTo(&Column{Type: field.TypeString}))
require.False(t, c1.ConvertibleTo(&Column{Type: field.TypeString, Size: 1}))
require.True(t, c1.ConvertibleTo(&Column{Type: field.TypeString, Size: 1}))
}
func TestColumn_ScanDefault(t *testing.T) {