From c4f13adea3ccbeee8a9133f2a95b00de2e992baf Mon Sep 17 00:00:00 2001 From: Ariel Mashraki Date: Tue, 2 Jul 2019 01:18:05 -0700 Subject: [PATCH] sql driver should not be opinionated about b configuration Reviewed By: elys1um Differential Revision: D16088072 fbshipit-source-id: ec50191ea3f159569d97b714863333795e96d57a --- dialect/sql/driver.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/dialect/sql/driver.go b/dialect/sql/driver.go index 5c0d8b10e..25574b261 100644 --- a/dialect/sql/driver.go +++ b/dialect/sql/driver.go @@ -11,10 +11,6 @@ import ( "fbc/ent/dialect" ) -// DefaultConnLifeTime to set the maximum amount of time a connection may be reused. -// MySQL server default values are: connect_timeout=10s and wait_timeout=28800s. -var DefaultConnLifeTime = 10 * time.Second - // Driver is a dialect.Driver implementation for SQL based databases. type Driver struct { conn @@ -27,7 +23,6 @@ func Open(driver, source string) (*Driver, error) { if err != nil { return nil, err } - db.SetConnMaxLifetime(DefaultConnLifeTime) return &Driver{conn{db}, driver}, nil } @@ -36,7 +31,7 @@ func OpenDB(driver string, db *sql.DB) *Driver { return &Driver{conn{db}, driver} } -// DB returns underlying *sql.DB instance. +// DB returns the underlying *sql.DB instance. func (d Driver) DB() *sql.DB { return d.conn.ExecQuerier.(*sql.DB) }