golang/ent
1
0
Fork 0
mirror of https://github.com/ent/ent.git synced 2026-05-01 07:00:57 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: checks for error after rows.Next call (#480)

Browse Source
This commit is contained in:
Ciaran Liedeman
2020-05-09 15:23:47 +02:00
committed by GitHub
parent 7f260c3ae0
commit f59abad425
5 changed files with 35 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dialect/sql/schema/sqlite.go
View File

@@ -168,6 +168,9 @@ func (d *SQLite) table(ctx context.Context, tx dialect.Tx, name string) (*Table,
}
t.AddColumn(c)
}
if rows.Err() != nil {
return nil, rows.Err()
}
if err := rows.Close(); err != nil {
return nil, fmt.Errorf("sqlite: closing rows %v", err)
}
@@ -215,6 +218,9 @@ func (d *SQLite) indexes(ctx context.Context, tx dialect.Tx, name string) (Index
i.primary = origin.String == "pk"
idx = append(idx, i)
}
if rows.Err() != nil {
return nil, rows.Err()
}
if err := rows.Close(); err != nil {
return nil, fmt.Errorf("closing rows %v", err)
}