mirror of
https://github.com/openai/codex.git
synced 2026-05-03 04:42:20 +03:00
Return image URL from view_image tool (#15072)
Cleanup image semantics in code mode.
`view_image` now returns `{image_url:string, details?: string}`
`image()` now allows both string parameter and `{image_url:string,
details?: string}`
This commit is contained in:
@@ -23,9 +23,26 @@ pub enum ImageProcessingError {
|
||||
#[source]
|
||||
source: image::ImageError,
|
||||
},
|
||||
#[error("unsupported image `{mime}`")]
|
||||
UnsupportedImageFormat { mime: String },
|
||||
}
|
||||
|
||||
impl ImageProcessingError {
|
||||
pub fn decode_error(path: &std::path::Path, source: image::ImageError) -> Self {
|
||||
if matches!(source, ImageError::Decoding(_)) {
|
||||
return ImageProcessingError::Decode {
|
||||
path: path.to_path_buf(),
|
||||
source,
|
||||
};
|
||||
}
|
||||
|
||||
let mime = mime_guess::from_path(path)
|
||||
.first()
|
||||
.map(|mime_guess| mime_guess.essence_str().to_owned())
|
||||
.unwrap_or_else(|| "unknown".to_string());
|
||||
ImageProcessingError::UnsupportedImageFormat { mime }
|
||||
}
|
||||
|
||||
pub fn is_invalid_image(&self) -> bool {
|
||||
matches!(
|
||||
self,
|
||||
|
||||
Reference in New Issue
Block a user