mirrors/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-04-29 02:41:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Simplify compaction analytics reducer emission

Browse Source
This commit is contained in:
Roy Han
2026-04-08 15:24:55 -07:00
parent 6636449efa
commit 61122ffaac
2 changed files with 22 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
codex-rs/analytics/src/analytics_client_tests.rs
View File

@@ -521,31 +521,30 @@ async fn initialize_caches_client_and_thread_lifecycle_publishes_once_initialize
}
#[tokio::test]
async fn compaction_event_waits_for_thread_connection_metadata() {
async fn compaction_event_uses_existing_thread_connection_metadata() {
let mut reducer = AnalyticsReducer::default();
let mut events = Vec::new();
let input = || CodexCompactionEvent {
thread_id: "thread-1".to_string(),
turn_id: "turn-compact".to_string(),
trigger: CompactionTrigger::Manual,
mode: CompactionMode::Local,
status: CompactionStatus::Failed,
error: Some("context limit exceeded".to_string()),
started_at: 100,
completed_at: 101,
duration_ms: Some(1200),
};
reducer
.ingest(
AnalyticsFact::Custom(CustomAnalyticsFact::Compaction(Box::new(
CodexCompactionEvent {
thread_id: "thread-1".to_string(),
turn_id: "turn-compact".to_string(),
trigger: CompactionTrigger::Manual,
mode: CompactionMode::Local,
status: CompactionStatus::Failed,
error: Some("context limit exceeded".to_string()),
started_at: 100,
completed_at: 101,
duration_ms: Some(1200),
},
))),
AnalyticsFact::Custom(CustomAnalyticsFact::Compaction(Box::new(input()))),
&mut events,
)
.await;
assert!(
events.is_empty(),
"compaction events should wait for client/runtime metadata"
"compaction events need existing client/runtime metadata"
);
reducer
@@ -587,6 +586,13 @@ async fn compaction_event_waits_for_thread_connection_metadata() {
)
.await;
reducer
.ingest(
AnalyticsFact::Custom(CustomAnalyticsFact::Compaction(Box::new(input()))),
&mut events,
)
.await;
let payload = serde_json::to_value(&events).expect("serialize events");
assert_eq!(payload.as_array().expect("events array").len(), 2);
assert_eq!(payload[0]["event_type"], "codex_thread_initialized");