jif-oai
2026-04-15 20:25:53 +01:00
committed by GitHub
parent 66533ddc61
commit 7e7b35b4d2
5 changed files with 33 additions and 4 deletions

View File

@@ -67,10 +67,12 @@ use std::future::Future;
use std::path::Path;
use std::path::PathBuf;
use std::sync::Arc;
use tracing::Level;
use tracing::error;
use tracing::warn;
use tracing_appender::non_blocking;
use tracing_subscriber::EnvFilter;
use tracing_subscriber::filter::Targets;
use tracing_subscriber::prelude::*;
use url::Url;
use uuid::Uuid;
@@ -237,6 +239,7 @@ pub use public_widgets::composer_input::ComposerAction;
pub use public_widgets::composer_input::ComposerInput;
// (tests access modules directly within the crate)
#[allow(clippy::too_many_arguments)]
async fn start_embedded_app_server(
arg0_paths: Arg0DispatchPaths,
config: Config,
@@ -244,6 +247,7 @@ async fn start_embedded_app_server(
loader_overrides: LoaderOverrides,
cloud_requirements: CloudRequirementsLoader,
feedback: codex_feedback::CodexFeedback,
log_db: Option<log_db::LogDbLayer>,
environment_manager: Arc<EnvironmentManager>,
) -> color_eyre::Result<InProcessAppServerClient> {
start_embedded_app_server_with(
@@ -253,6 +257,7 @@ async fn start_embedded_app_server(
loader_overrides,
cloud_requirements,
feedback,
log_db,
environment_manager,
InProcessAppServerClient::start,
)
@@ -369,6 +374,7 @@ async fn start_app_server(
loader_overrides: LoaderOverrides,
cloud_requirements: CloudRequirementsLoader,
feedback: codex_feedback::CodexFeedback,
log_db: Option<log_db::LogDbLayer>,
environment_manager: Arc<EnvironmentManager>,
) -> color_eyre::Result<AppServerClient> {
match target {
@@ -379,6 +385,7 @@ async fn start_app_server(
loader_overrides,
cloud_requirements,
feedback,
log_db,
environment_manager,
)
.await
@@ -403,6 +410,7 @@ pub(crate) async fn start_app_server_for_picker(
LoaderOverrides::default(),
CloudRequirementsLoader::default(),
codex_feedback::CodexFeedback::new(),
/*log_db*/ None,
environment_manager,
)
.await?;
@@ -429,6 +437,7 @@ async fn start_embedded_app_server_with<F, Fut>(
loader_overrides: LoaderOverrides,
cloud_requirements: CloudRequirementsLoader,
feedback: codex_feedback::CodexFeedback,
log_db: Option<log_db::LogDbLayer>,
environment_manager: Arc<EnvironmentManager>,
start_client: F,
) -> color_eyre::Result<InProcessAppServerClient>
@@ -453,6 +462,7 @@ where
loader_overrides,
cloud_requirements,
feedback,
log_db,
environment_manager,
config_warnings,
session_source: codex_protocol::protocol::SessionSource::Cli,
@@ -969,9 +979,10 @@ pub async fn run_main(
let otel_tracing_layer = otel.as_ref().and_then(|o| o.tracing_layer());
let log_db_layer = get_state_db(&config)
.await
.map(|db| log_db::start(db).with_filter(env_filter()));
let log_db = get_state_db(&config).await.map(log_db::start);
let log_db_layer = log_db
.clone()
.map(|layer| layer.with_filter(Targets::new().with_default(Level::TRACE)));
let _ = tracing_subscriber::registry()
.with(file_layer)
@@ -993,6 +1004,7 @@ pub async fn run_main(
cli_kv_overrides,
cloud_requirements,
feedback,
log_db,
remote_url,
remote_auth_token,
environment_manager,
@@ -1013,6 +1025,7 @@ async fn run_ratatui_app(
cli_kv_overrides: Vec<(String, toml::Value)>,
mut cloud_requirements: CloudRequirementsLoader,
feedback: codex_feedback::CodexFeedback,
log_db: Option<log_db::LogDbLayer>,
remote_url: Option<String>,
remote_auth_token: Option<String>,
environment_manager: Arc<EnvironmentManager>,
@@ -1071,6 +1084,7 @@ async fn run_ratatui_app(
loader_overrides.clone(),
cloud_requirements.clone(),
feedback.clone(),
log_db.clone(),
environment_manager.clone(),
)
.await
@@ -1409,6 +1423,7 @@ async fn run_ratatui_app(
loader_overrides,
cloud_requirements.clone(),
feedback.clone(),
log_db.clone(),
environment_manager.clone(),
)
.await
@@ -1772,6 +1787,7 @@ mod tests {
LoaderOverrides::default(),
CloudRequirementsLoader::default(),
codex_feedback::CodexFeedback::new(),
/*log_db*/ None,
Arc::new(EnvironmentManager::new(/*exec_server_url*/ None)),
)
.await
@@ -2163,6 +2179,7 @@ mod tests {
LoaderOverrides::default(),
CloudRequirementsLoader::default(),
codex_feedback::CodexFeedback::new(),
/*log_db*/ None,
Arc::new(EnvironmentManager::new(/*exec_server_url*/ None)),
|_args| async { Err(std::io::Error::other("boom")) },
)