mirrors/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-05-03 12:52:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix: harden plugin feature gating" (#15102)

Browse Source 
Reverts openai/codex#15020

I messed up the commit in my PR and accidentally merged changes that
were still under review.
This commit is contained in:
xl-openai
2026-03-18 15:19:29 -07:00
committed by GitHub
parent e5de13644d
commit 86982ca1f9
40 changed files with 52 additions and 926 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
codex-rs/cli/src/main.rs
View File

@@ -331,17 +331,6 @@ struct AppServerCommand {
)]
listen: codex_app_server::AppServerTransport,
/// Session source stamped into new threads started by this app-server.
///
/// Known values such as `vscode`, `cli`, `exec`, and `mcp` map to built-in
/// sources. Any other non-empty value is recorded as a custom source.
#[arg(
long = "session-source",
value_name = "SOURCE",
default_value = "vscode"
)]
session_source: String,
/// Controls whether analytics are enabled by default.
///
/// Analytics are disabled by default for app-server. Users have to explicitly opt in
@@ -654,17 +643,12 @@ async fn cli_main(arg0_paths: Arg0DispatchPaths) -> anyhow::Result<()> {
None => {
reject_remote_mode_for_subcommand(root_remote.as_deref(), "app-server")?;
let transport = app_server_cli.listen;
let session_source = codex_protocol::protocol::SessionSource::from_startup_arg(
app_server_cli.session_source.as_str(),
)
.map_err(|err| anyhow::anyhow!("invalid --session-source: {err}"))?;
codex_app_server::run_main_with_transport(
arg0_paths.clone(),
root_config_overrides,
codex_core::config_loader::LoaderOverrides::default(),
app_server_cli.analytics_default_enabled,
transport,
session_source,
)
.await?;
}
@@ -1631,7 +1615,6 @@ mod tests {
app_server.listen,
codex_app_server::AppServerTransport::Stdio
);
assert_eq!(app_server.session_source, "vscode");
}
#[test]
@@ -1641,13 +1624,6 @@ mod tests {
assert!(app_server.analytics_default_enabled);
}
#[test]
fn app_server_session_source_accepts_custom_value() {
let app_server =
app_server_from_args(["codex", "app-server", "--session-source", "atlas"].as_ref());
assert_eq!(app_server.session_source, "atlas");
}
#[test]
fn remote_flag_parses_for_interactive_root() {
let cli = MultitoolCli::try_parse_from(["codex", "--remote", "ws://127.0.0.1:4500"])