Apply argument comment lint across codex-rs (#14652)

## Why

Once the repo-local lint exists, `codex-rs` needs to follow the
checked-in convention and CI needs to keep it from drifting. This commit
applies the fallback `/*param*/` style consistently across existing
positional literal call sites without changing those APIs.

The longer-term preference is still to avoid APIs that require comments
by choosing clearer parameter types and call shapes. This PR is
intentionally the mechanical follow-through for the places where the
existing signatures stay in place.

After rebasing onto newer `main`, the rollout also had to cover newly
introduced `tui_app_server` call sites. That made it clear the first cut
of the CI job was too expensive for the common path: it was spending
almost as much time installing `cargo-dylint` and re-testing the lint
crate as a representative test job spends running product tests. The CI
update keeps the full workspace enforcement but trims that extra
overhead from ordinary `codex-rs` PRs.

## What changed

- keep a dedicated `argument_comment_lint` job in `rust-ci`
- mechanically annotate remaining opaque positional literals across
`codex-rs` with exact `/*param*/` comments, including the rebased
`tui_app_server` call sites that now fall under the lint
- keep the checked-in style aligned with the lint policy by using
`/*param*/` and leaving string and char literals uncommented
- cache `cargo-dylint`, `dylint-link`, and the relevant Cargo
registry/git metadata in the lint job
- split changed-path detection so the lint crate's own `cargo test` step
runs only when `tools/argument-comment-lint/*` or `rust-ci.yml` changes
- continue to run the repo wrapper over the `codex-rs` workspace, so
product-code enforcement is unchanged

Most of the code changes in this commit are intentionally mechanical
comment rewrites or insertions driven by the lint itself.

## Verification

- `./tools/argument-comment-lint/run.sh --workspace`
- `cargo test -p codex-tui-app-server -p codex-tui`
- parsed `.github/workflows/rust-ci.yml` locally with PyYAML

---

* -> #14652
* #14651
This commit is contained in:
Michael Bolin
2026-03-16 16:48:15 -07:00
committed by GitHub
parent 6f05d8d735
commit b77fe8fefe
261 changed files with 2311 additions and 1377 deletions

View File

@@ -782,7 +782,7 @@ fn truncate_exec_snippet(full_cmd: &str) -> String {
Some((first, _)) => format!("{first} ..."),
None => full_cmd.to_string(),
};
snippet = truncate_text(&snippet, 80);
snippet = truncate_text(&snippet, /*max_graphemes*/ 80);
snippet
}
@@ -1003,7 +1003,7 @@ pub(crate) fn card_inner_width(width: u16, max_inner_width: usize) -> Option<usi
/// Render `lines` inside a border sized to the widest span in the content.
pub(crate) fn with_border(lines: Vec<Line<'static>>) -> Vec<Line<'static>> {
with_border_internal(lines, None)
with_border_internal(lines, /*forced_inner_width*/ None)
}
/// Render `lines` inside a border whose inner width is at least `inner_width`.
@@ -1660,7 +1660,7 @@ pub(crate) fn new_active_web_search_call(
query: String,
animations_enabled: bool,
) -> WebSearchCell {
WebSearchCell::new(call_id, query, None, animations_enabled)
WebSearchCell::new(call_id, query, /*action*/ None, animations_enabled)
}
pub(crate) fn new_web_search_call(
@@ -1668,7 +1668,12 @@ pub(crate) fn new_web_search_call(
query: String,
action: WebSearchAction,
) -> WebSearchCell {
let mut cell = WebSearchCell::new(call_id, query, Some(action), false);
let mut cell = WebSearchCell::new(
call_id,
query,
Some(action),
/*animations_enabled*/ false,
);
cell.complete();
cell
}
@@ -1812,7 +1817,7 @@ pub(crate) fn new_mcp_tools_output(
}
let mcp_manager = McpManager::new(Arc::new(PluginsManager::new(config.codex_home.clone())));
let effective_servers = mcp_manager.effective_servers(config, None);
let effective_servers = mcp_manager.effective_servers(config, /*auth*/ None);
let mut servers: Vec<_> = effective_servers.iter().collect();
servers.sort_by(|(a, _), (b, _)| a.cmp(b));
@@ -2345,7 +2350,7 @@ pub(crate) fn new_reasoning_summary_block(
header_buffer,
summary_buffer,
&cwd,
false,
/*transcript_only*/ false,
));
}
}
@@ -2354,7 +2359,7 @@ pub(crate) fn new_reasoning_summary_block(
"".to_string(),
full_reasoning_buffer.to_string(),
&cwd,
true,
/*transcript_only*/ true,
))
}