Wire with_remote_overrides to construct model families (#7621)

- This PR wires `with_remote_overrides` and make the
`construct_model_families` an async function
- Moves getting model family a level above to keep the function `sync`
- Updates the tests to local, offline, and `sync` helper for model
families

codex-rs/tui/src/history_cell.rs

@@ -27,7 +27,6 @@ use codex_common::format_env_display::format_env_display;
 use codex_core::config::Config;
 use codex_core::config::types::McpServerTransportConfig;
 use codex_core::config::types::ReasoningSummaryFormat;
-use codex_core::openai_models::model_family::ModelFamily;
 use codex_core::protocol::FileChange;
 use codex_core::protocol::McpAuthStatus;
 use codex_core::protocol::McpInvocation;
@@ -1421,9 +1420,9 @@ pub(crate) fn new_view_image_tool_call(path: PathBuf, cwd: &Path) -> PlainHistor
 
 pub(crate) fn new_reasoning_summary_block(
     full_reasoning_buffer: String,
-    model_family: &ModelFamily,
+    reasoning_summary_format: ReasoningSummaryFormat,
 ) -> Box<dyn HistoryCell> {
-    if model_family.reasoning_summary_format == ReasoningSummaryFormat::Experimental {
+    if reasoning_summary_format == ReasoningSummaryFormat::Experimental {
         // Experimental format is following:
         // ** header **
         //
@@ -1513,8 +1512,6 @@ mod tests {
     use crate::exec_cell::CommandOutput;
     use crate::exec_cell::ExecCall;
     use crate::exec_cell::ExecCell;
-    use codex_core::AuthManager;
-    use codex_core::CodexAuth;
     use codex_core::config::Config;
     use codex_core::config::ConfigOverrides;
     use codex_core::config::ConfigToml;
@@ -1527,7 +1524,6 @@ mod tests {
     use pretty_assertions::assert_eq;
     use serde_json::json;
     use std::collections::HashMap;
-    use std::sync::Arc;
 
     use codex_core::protocol::ExecCommandSource;
     use mcp_types::CallToolResult;
@@ -2326,13 +2322,12 @@ mod tests {
     #[test]
     fn reasoning_summary_block() {
         let config = test_config();
-        let auth_manager =
-            AuthManager::from_auth_for_testing(CodexAuth::from_api_key("Test API Key"));
-        let models_manager = Arc::new(ModelsManager::new(auth_manager));
-        let model_family = models_manager.construct_model_family(&config.model, &config);
+        let reasoning_format =
+            ModelsManager::construct_model_family_offline(&config.model, &config)
+                .reasoning_summary_format;
         let cell = new_reasoning_summary_block(
             "**High level reasoning**\n\nDetailed reasoning goes here.".to_string(),
-            &model_family,
+            reasoning_format,
         );
 
         let rendered_display = render_lines(&cell.display_lines(80));
@@ -2345,12 +2340,13 @@ mod tests {
     #[test]
     fn reasoning_summary_block_returns_reasoning_cell_when_feature_disabled() {
         let config = test_config();
-        let auth_manager =
-            AuthManager::from_auth_for_testing(CodexAuth::from_api_key("Test API Key"));
-        let models_manager = Arc::new(ModelsManager::new(auth_manager));
-        let model_family = models_manager.construct_model_family(&config.model, &config);
-        let cell =
-            new_reasoning_summary_block("Detailed reasoning goes here.".to_string(), &model_family);
+        let reasoning_format =
+            ModelsManager::construct_model_family_offline(&config.model, &config)
+                .reasoning_summary_format;
+        let cell = new_reasoning_summary_block(
+            "Detailed reasoning goes here.".to_string(),
+            reasoning_format,
+        );
 
         let rendered = render_transcript(cell.as_ref());
         assert_eq!(rendered, vec!["• Detailed reasoning goes here."]);
@@ -2362,11 +2358,7 @@ mod tests {
         config.model = "gpt-3.5-turbo".to_string();
         config.model_supports_reasoning_summaries = Some(true);
         config.model_reasoning_summary_format = Some(ReasoningSummaryFormat::Experimental);
-        let auth_manager =
-            AuthManager::from_auth_for_testing(CodexAuth::from_api_key("Test API Key"));
-        let models_manager = Arc::new(ModelsManager::new(auth_manager));
-
-        let model_family = models_manager.construct_model_family(&config.model, &config);
+        let model_family = ModelsManager::construct_model_family_offline(&config.model, &config);
         assert_eq!(
             model_family.reasoning_summary_format,
             ReasoningSummaryFormat::Experimental
@@ -2374,7 +2366,7 @@ mod tests {
 
         let cell = new_reasoning_summary_block(
             "**High level reasoning**\n\nDetailed reasoning goes here.".to_string(),
-            &model_family,
+            model_family.reasoning_summary_format,
         );
 
         let rendered_display = render_lines(&cell.display_lines(80));
@@ -2384,13 +2376,12 @@ mod tests {
     #[test]
     fn reasoning_summary_block_falls_back_when_header_is_missing() {
         let config = test_config();
-        let auth_manager =
-            AuthManager::from_auth_for_testing(CodexAuth::from_api_key("Test API Key"));
-        let models_manager = Arc::new(ModelsManager::new(auth_manager));
-        let model_family = models_manager.construct_model_family(&config.model, &config);
+        let reasoning_format =
+            ModelsManager::construct_model_family_offline(&config.model, &config)
+                .reasoning_summary_format;
         let cell = new_reasoning_summary_block(
             "**High level reasoning without closing".to_string(),
-            &model_family,
+            reasoning_format,
         );
 
         let rendered = render_transcript(cell.as_ref());
@@ -2400,13 +2391,12 @@ mod tests {
     #[test]
     fn reasoning_summary_block_falls_back_when_summary_is_missing() {
         let config = test_config();
-        let auth_manager =
-            AuthManager::from_auth_for_testing(CodexAuth::from_api_key("Test API Key"));
-        let models_manager = Arc::new(ModelsManager::new(auth_manager));
-        let model_family = models_manager.construct_model_family(&config.model, &config);
+        let reasoning_format =
+            ModelsManager::construct_model_family_offline(&config.model, &config)
+                .reasoning_summary_format;
         let cell = new_reasoning_summary_block(
             "**High level reasoning without closing**".to_string(),
-            &model_family,
+            reasoning_format.clone(),
         );
 
         let rendered = render_transcript(cell.as_ref());
@@ -2414,7 +2404,7 @@ mod tests {
 
         let cell = new_reasoning_summary_block(
             "**High level reasoning without closing**\n\n  ".to_string(),
-            &model_family,
+            reasoning_format,
         );
 
         let rendered = render_transcript(cell.as_ref());
@@ -2424,13 +2414,12 @@ mod tests {
     #[test]
     fn reasoning_summary_block_splits_header_and_summary_when_present() {
         let config = test_config();
-        let auth_manager =
-            AuthManager::from_auth_for_testing(CodexAuth::from_api_key("Test API Key"));
-        let models_manager = Arc::new(ModelsManager::new(auth_manager));
-        let model_family = models_manager.construct_model_family(&config.model, &config);
+        let reasoning_format =
+            ModelsManager::construct_model_family_offline(&config.model, &config)
+                .reasoning_summary_format;
         let cell = new_reasoning_summary_block(
             "**High level plan**\n\nWe should fix the bug next.".to_string(),
-            &model_family,
+            reasoning_format,
         );
 
         let rendered_display = render_lines(&cell.display_lines(80));