From e720beeef48e744db4e63c1ebac7e0fcba4e9090 Mon Sep 17 00:00:00 2001 From: Eric Traut Date: Sun, 12 Apr 2026 19:40:43 -0700 Subject: [PATCH] codex: address PR review feedback (#17579) --- codex-rs/core/src/codex/timer_runtime.rs | 26 ++++++++++-------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/codex-rs/core/src/codex/timer_runtime.rs b/codex-rs/core/src/codex/timer_runtime.rs index cebba5767d..f5557a9889 100644 --- a/codex-rs/core/src/codex/timer_runtime.rs +++ b/codex-rs/core/src/codex/timer_runtime.rs @@ -310,23 +310,19 @@ impl Session { } async fn inject_timer_into_active_turn(&self, item: PendingInputItem) -> bool { - let turn_state = { - let active = self.active_turn.lock().await; - let Some(active_turn) = active.as_ref() else { - return false; - }; - - match active_turn.tasks.first().map(|(_, task)| task.kind) { - Some(crate::state::TaskKind::Regular) => Arc::clone(&active_turn.turn_state), - Some(crate::state::TaskKind::Review | crate::state::TaskKind::Compact) | None => { - return false; - } - } + let active = self.active_turn.lock().await; + let Some(active_turn) = active.as_ref() else { + return false; }; - let mut turn_state = turn_state.lock().await; - turn_state.push_pending_input(item); - true + match active_turn.tasks.first().map(|(_, task)| task.kind) { + Some(crate::state::TaskKind::Regular) => { + let mut turn_state = active_turn.turn_state.lock().await; + turn_state.push_pending_input(item); + true + } + Some(crate::state::TaskKind::Review | crate::state::TaskKind::Compact) | None => false, + } } fn spawn_timer_task(