mirrors/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-05-03 12:52:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

codex: address PR review feedback (#15687)

Browse Source 
Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
Michael Fan
2026-03-27 15:37:10 -04:00
parent b361da8f82
commit fe2db27804
2 changed files with 34 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
codex-rs/app-server/tests/suite/v2/thread_shell_command.rs
View File

@@ -81,7 +81,7 @@ async fn thread_env_contains_checks_process_env() -> Result<()> {
let contains_id = mcp
.send_thread_env_contains_request(ThreadEnvContainsParams {
thread_id: thread.id,
thread_id: thread.id.clone(),
key: PROCESS_ENV_KEY.to_string(),
})
.await?;
@@ -93,6 +93,33 @@ async fn thread_env_contains_checks_process_env() -> Result<()> {
let contains = to_response::<ThreadEnvContainsResponse>(contains_resp)?;
assert_eq!(contains, ThreadEnvContainsResponse { contains: true });
let set_id = mcp
.send_thread_dependency_env_set_request(ThreadDependencyEnvSetParams {
thread_id: thread.id.clone(),
values: HashMap::from([(PROCESS_ENV_KEY.to_string(), String::new())]),
})
.await?;
let set_resp: JSONRPCResponse = timeout(
DEFAULT_READ_TIMEOUT,
mcp.read_stream_until_response_message(RequestId::Integer(set_id)),
)
.await??;
let _: ThreadDependencyEnvSetResponse = to_response(set_resp)?;
let contains_id = mcp
.send_thread_env_contains_request(ThreadEnvContainsParams {
thread_id: thread.id,
key: PROCESS_ENV_KEY.to_string(),
})
.await?;
let contains_resp: JSONRPCResponse = timeout(
DEFAULT_READ_TIMEOUT,
mcp.read_stream_until_response_message(RequestId::Integer(contains_id)),
)
.await??;
let contains = to_response::<ThreadEnvContainsResponse>(contains_resp)?;
assert_eq!(contains, ThreadEnvContainsResponse { contains: false });
Ok(())
}