mirror of
https://github.com/openai/codex.git
synced 2026-05-05 05:42:33 +03:00
0c8a36676a
## Why PR #13783 moved the `codex.rs` unit tests into `codex_tests.rs`. This applies the same extraction pattern across the rest of `codex-rs/core` so the production modules stay focused on runtime code instead of large inline test blocks. Keeping the tests in sibling files also makes follow-up edits easier to review because product changes no longer have to share a file with hundreds or thousands of lines of test scaffolding. ## What changed - replaced each inline `mod tests { ... }` in `codex-rs/core/src/**` with a path-based module declaration - moved each extracted unit test module into a sibling `*_tests.rs` file, using `mod_tests.rs` for `mod.rs` modules - preserved the existing `cfg(...)` guards and module-local structure so the refactor remains structural rather than behavioral ## Testing - `cargo test -p codex-core --lib` (`1653 passed; 0 failed; 5 ignored`) - `just fix -p codex-core` - `cargo fmt --check` - `cargo shear`
34 lines
1.2 KiB
Rust
34 lines
1.2 KiB
Rust
const DEFAULT_ATTRIBUTION_VALUE: &str = "Codex <noreply@openai.com>";
|
|
|
|
fn build_commit_message_trailer(config_attribution: Option<&str>) -> Option<String> {
|
|
let value = resolve_attribution_value(config_attribution)?;
|
|
Some(format!("Co-authored-by: {value}"))
|
|
}
|
|
|
|
pub(crate) fn commit_message_trailer_instruction(
|
|
config_attribution: Option<&str>,
|
|
) -> Option<String> {
|
|
let trailer = build_commit_message_trailer(config_attribution)?;
|
|
Some(format!(
|
|
"When you write or edit a git commit message, ensure the message ends with this trailer exactly once:\n{trailer}\n\nRules:\n- Keep existing trailers and append this trailer at the end if missing.\n- Do not duplicate this trailer if it already exists.\n- Keep one blank line between the commit body and trailer block."
|
|
))
|
|
}
|
|
|
|
fn resolve_attribution_value(config_attribution: Option<&str>) -> Option<String> {
|
|
match config_attribution {
|
|
Some(value) => {
|
|
let trimmed = value.trim();
|
|
if trimmed.is_empty() {
|
|
None
|
|
} else {
|
|
Some(trimmed.to_string())
|
|
}
|
|
}
|
|
None => Some(DEFAULT_ATTRIBUTION_VALUE.to_string()),
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
#[path = "commit_attribution_tests.rs"]
|
|
mod tests;
|