Fix chat completions tui (#1843)

codex-rs/tui/src/bottom_pane/mod.rs

@@ -202,15 +202,20 @@ impl BottomPane<'_> {
             handled_by_view = true;
         }
 
-        // Fallback: if the current active view did not consume status updates,
-        // present an overlay above the composer.
-        if !handled_by_view {
+        // Fallback: if the current active view did not consume status updates
+        // and no modal view is active, present an overlay above the composer.
+        // If a modal is active, do NOT render the overlay to avoid drawing
+        // over the dialog.
+        if !handled_by_view && self.active_view.is_none() {
             if self.live_status.is_none() {
                 self.live_status = Some(StatusIndicatorWidget::new(self.app_event_tx.clone()));
             }
             if let Some(status) = &mut self.live_status {
                 status.update_text(text);
             }
+        } else if !handled_by_view {
+            // Ensure any previous overlay is cleared when a modal becomes active.
+            self.live_status = None;
         }
         self.request_redraw();
     }
@@ -296,6 +301,8 @@ impl BottomPane<'_> {
         // Otherwise create a new approval modal overlay.
         let modal = ApprovalModalView::new(request, self.app_event_tx.clone());
         self.active_view = Some(Box::new(modal));
+        // Hide any overlay status while a modal is visible.
+        self.live_status = None;
         self.status_view_active = false;
         self.request_redraw()
     }
@@ -368,16 +375,18 @@ impl WidgetRef for &BottomPane<'_> {
             y_offset = y_offset.saturating_add(1);
         }
         if let Some(status) = &self.live_status {
-            let live_h = status.desired_height(area.width).min(area.height);
+            let live_h = status
+                .desired_height(area.width)
+                .min(area.height.saturating_sub(y_offset));
             if live_h > 0 {
                 let live_rect = Rect {
                     x: area.x,
-                    y: area.y,
+                    y: area.y + y_offset,
                     width: area.width,
                     height: live_h,
                 };
                 status.render_ref(live_rect, buf);
-                y_offset = live_h;
+                y_offset = y_offset.saturating_add(live_h);
             }
         }
 
@@ -540,6 +549,75 @@ mod tests {
         );
     }
 
+    #[test]
+    fn overlay_not_shown_above_approval_modal() {
+        let (tx_raw, _rx) = channel::<AppEvent>();
+        let tx = AppEventSender::new(tx_raw);
+        let mut pane = BottomPane::new(BottomPaneParams {
+            app_event_tx: tx,
+            has_input_focus: true,
+            enhanced_keys_supported: false,
+        });
+
+        // Create an approval modal (active view).
+        pane.push_approval_request(exec_request());
+        // Attempt to update status; this should NOT create an overlay while modal is visible.
+        pane.update_status_text("running command".to_string());
+
+        // Render and verify the top row does not include the Working header overlay.
+        let area = Rect::new(0, 0, 60, 6);
+        let mut buf = Buffer::empty(area);
+        (&pane).render_ref(area, &mut buf);
+
+        let mut r0 = String::new();
+        for x in 0..area.width {
+            r0.push(buf[(x, 0)].symbol().chars().next().unwrap_or(' '));
+        }
+        assert!(
+            !r0.contains("Working"),
+            "overlay Working header should not render above modal"
+        );
+    }
+
+    #[test]
+    fn status_indicator_visible_during_command_execution() {
+        let (tx_raw, _rx) = channel::<AppEvent>();
+        let tx = AppEventSender::new(tx_raw);
+        let mut pane = BottomPane::new(BottomPaneParams {
+            app_event_tx: tx,
+            has_input_focus: true,
+            enhanced_keys_supported: false,
+        });
+
+        // Begin a task: show initial status.
+        pane.set_task_running(true);
+        pane.update_status_text("waiting for model".to_string());
+
+        // Simulate an approval modal which temporarily hides the status view.
+        pane.push_approval_request(exec_request());
+
+        // Re-enable a status line as would happen when a long-running command begins.
+        // This should present the status indicator even while modal logic may be active.
+        pane.update_status_text("running command".to_string());
+
+        // Allow some frames so the animation thread ticks.
+        std::thread::sleep(std::time::Duration::from_millis(120));
+
+        // Render and confirm the line contains the "Working" header.
+        let area = Rect::new(0, 0, 40, 3);
+        let mut buf = Buffer::empty(area);
+        (&pane).render_ref(area, &mut buf);
+
+        let mut row0 = String::new();
+        for x in 0..area.width {
+            row0.push(buf[(x, 0)].symbol().chars().next().unwrap_or(' '));
+        }
+        assert!(
+            row0.contains("Working"),
+            "expected Working header: {row0:?}"
+        );
+    }
+
     #[test]
     fn bottom_padding_present_for_status_view() {
         let (tx_raw, _rx) = channel::<AppEvent>();

codex-rs/tui/src/chatwidget.rs

@@ -104,6 +104,24 @@ fn create_initial_user_message(text: String, image_paths: Vec<PathBuf>) -> Optio
 }
 
 impl ChatWidget<'_> {
+    fn emit_stream_header(&mut self, kind: StreamKind) {
+        use ratatui::text::Line as RLine;
+        if self.stream_header_emitted {
+            return;
+        }
+        let header = match kind {
+            StreamKind::Reasoning => RLine::from("thinking".magenta().italic()),
+            StreamKind::Answer => RLine::from("codex".magenta().bold()),
+        };
+        self.app_event_tx
+            .send(AppEvent::InsertHistory(vec![header]));
+        self.stream_header_emitted = true;
+    }
+    fn finalize_active_stream(&mut self) {
+        if let Some(kind) = self.current_stream {
+            self.finalize_stream(kind);
+        }
+    }
     pub(crate) fn new(
         config: Config,
         app_event_tx: AppEventSender,
@@ -336,6 +354,7 @@ impl ChatWidget<'_> {
                 cwd,
                 reason,
             }) => {
+                self.finalize_active_stream();
                 // Log a background summary immediately so the history is chronological.
                 let cmdline = strip_bash_lc_and_escape(&command);
                 let text = format!(
@@ -362,6 +381,7 @@ impl ChatWidget<'_> {
                 reason,
                 grant_root,
             }) => {
+                self.finalize_active_stream();
                 // ------------------------------------------------------------------
                 // Before we even prompt the user for approval we surface the patch
                 // summary in the main conversation so that the dialog appears in a
@@ -391,6 +411,10 @@ impl ChatWidget<'_> {
                 command,
                 cwd,
             }) => {
+                self.finalize_active_stream();
+                // Ensure the status indicator is visible while the command runs.
+                self.bottom_pane
+                    .update_status_text("running command".to_string());
                 self.running_commands.insert(
                     call_id,
                     RunningCommand {
@@ -434,6 +458,7 @@ impl ChatWidget<'_> {
                 call_id: _,
                 invocation,
             }) => {
+                self.finalize_active_stream();
                 self.add_to_history(HistoryCell::new_active_mcp_tool_call(invocation));
             }
             EventMsg::McpToolCallEnd(McpToolCallEndEvent {
@@ -567,6 +592,7 @@ impl ChatWidget<'_> {
             // Ensure the waiting status is visible (composer replaced).
             self.bottom_pane
                 .update_status_text("waiting for model".to_string());
+            self.emit_stream_header(kind);
         }
     }