sql driver should not be opinionated about b configuration

Reviewed By: elys1um

Differential Revision: D16088072

fbshipit-source-id: ec50191ea3f159569d97b714863333795e96d57a
This commit is contained in:
Ariel Mashraki
2019-07-02 01:18:05 -07:00
committed by Facebook Github Bot
parent e8e96f014f
commit c4f13adea3

View File

@@ -11,10 +11,6 @@ import (
"fbc/ent/dialect"
)
// DefaultConnLifeTime to set the maximum amount of time a connection may be reused.
// MySQL server default values are: connect_timeout=10s and wait_timeout=28800s.
var DefaultConnLifeTime = 10 * time.Second
// Driver is a dialect.Driver implementation for SQL based databases.
type Driver struct {
conn
@@ -27,7 +23,6 @@ func Open(driver, source string) (*Driver, error) {
if err != nil {
return nil, err
}
db.SetConnMaxLifetime(DefaultConnLifeTime)
return &Driver{conn{db}, driver}, nil
}
@@ -36,7 +31,7 @@ func OpenDB(driver string, db *sql.DB) *Driver {
return &Driver{conn{db}, driver}
}
// DB returns underlying *sql.DB instance.
// DB returns the underlying *sql.DB instance.
func (d Driver) DB() *sql.DB {
return d.conn.ExecQuerier.(*sql.DB)
}