Compare commits

...

2 Commits

Author SHA1 Message Date
Eric Traut
9c635f5141 Merge branch 'main' into etraut/issue-13595 2026-03-05 11:54:28 -07:00
Eric Traut
152fb27860 Investigate codex bug 13595 2026-03-05 11:53:43 -07:00
2 changed files with 9 additions and 7 deletions

View File

@@ -3659,8 +3659,7 @@ impl ChatWidget {
else {
return;
};
let should_submit_now =
self.is_session_configured() && !self.is_plan_streaming_in_tui();
let should_submit_now = self.is_session_configured();
if should_submit_now {
// Submitted is emitted when user submits.
// Reset any reasoning header only when we are actually submitting a turn.

View File

@@ -3849,7 +3849,7 @@ async fn unified_exec_begin_restores_working_status_snapshot() {
}
#[tokio::test]
async fn steer_enter_queues_while_plan_stream_is_active() {
async fn steer_enter_uses_pending_steers_while_plan_stream_is_active() {
let (mut chat, mut rx, mut op_rx) = make_chatwidget_manual(None).await;
chat.thread_id = Some(ThreadId::new());
chat.set_feature_enabled(Feature::CollaborationModes, true);
@@ -3866,13 +3866,16 @@ async fn steer_enter_queues_while_plan_stream_is_active() {
chat.handle_key_event(KeyEvent::new(KeyCode::Enter, KeyModifiers::NONE));
assert_eq!(chat.active_collaboration_mode_kind(), ModeKind::Plan);
assert_eq!(chat.queued_user_messages.len(), 1);
assert!(chat.queued_user_messages.is_empty());
assert_eq!(chat.pending_steers.len(), 1);
assert_eq!(
chat.queued_user_messages.front().unwrap().text,
chat.pending_steers.front().unwrap().user_message.text,
"queued submission"
);
assert!(chat.pending_steers.is_empty());
assert_no_submit_op(&mut op_rx);
match next_submit_op(&mut op_rx) {
Op::UserTurn { .. } => {}
other => panic!("expected Op::UserTurn, got {other:?}"),
}
assert!(drain_insert_history(&mut rx).is_empty());
}